WIP - James to look at fix for empty partitions in bootstrap replication (MF bootstrap mechanism) #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a bug that becomes apparent after fixing the original bug: Not all partitions in the bootstrap replication are necessarily be filled, yielding NaN values when the statistic is calculated. Add data validation to ensure only calculating statistic on partitions that contain values.
Will discuss with Ira which option is best
…an of the partition means (instead of the sum)
…n instead of sum. This addresses the huge standard error that results from bootstrapping. This was another bug found after fixing Issue #49.
…the HUGE standard error on the differentially private bootstrapped mean.)
MeganFantes
changed the title
added 4 commits
October 1, 2019 13:56
Merge branch 'develop' of https://github.com/privacytoolsproject/PSI-Library into MF_Issue49_bugFix_bootStatEval # Conflicts: # .gitignore # NAMESPACE # R/mechanism-bootstrap.R # man/Laplace-Mechanism.Rd # vignettes/dp-mean.Rmd
|
As of earlier this week, I have fixed the merge conflicts in this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the
R/mechanism-bootstrap.RfileAt the top (line 13) there is a comment that says:
# There are 2 options for handling empty partitions:Below this comment, the two options for handling empty partitions are fully implemented, tested, and commented.
James, I would just like to hear from you which option is best.
Briefly, the two options for handling empty partitions are: